Open
Conversation
mega-yujin
added
the
ready for review
Chudopal
reviewed
Sep 8, 2022
Owner
Chudopal
left a comment
Chudopal
left a comment
There was a problem hiding this comment.
Красиво сделано, многие идеи мне нравятся, функции небольшие, по большей части независимые, круто!
Исправь замечания или обоснуй, почему так как ты решил - более правильно будет, и можно мержить
Comment on lines
5
to
6
| cats: int | ||
| dogs: int |
Owner
There was a problem hiding this comment.
Позволь пользователю вообще не задавать что-то, вдруг ему не интересны факты о собаках
|
|
||
|
|
||
| class ResponseInfo(BaseModel): | ||
| cats: tuple[str, ...] |
Owner
There was a problem hiding this comment.
ну этот тупо может содержать либо строку либо ничего, в модели этого не видно
Collaborator
Author
There was a problem hiding this comment.
А как тогда правильно? list[str] ?
| DOGS_URL = 'http://dog-api.kinduff.com/api/facts' | ||
|
|
||
|
|
||
| async def get_facts(url: str, params: dict = None): |
Owner
There was a problem hiding this comment.
обычно в сигнатуре функций в проекте с FastAPI принято писать Optional[dict] или Union[dict, None], а не задавать явно None
Chudopal
added
in progress
mega-yujin
added
the
ready for review
mega-yujin
removed
the
in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.